Fix BreakingBytesRefBuilderTests testGrow failing #100547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
added
>test
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
ChrisHegarty
added
auto-merge-without-approval
nik9000
approved these changes
Oct 9, 2023
|
Ah! It's when it guesses how big the oversize will be! That makes sense! Thanks! |
ChrisHegarty
added a commit
to ChrisHegarty/elasticsearch
that referenced
this pull request
Oct 9, 2023
This commit fixes the intermittent failure of BreakingBytesRefBuilderTests. The issue is that the test uses the BreakingBytesRefBuilder's internal BytesRef array length to determine whether to expect a circuit breaker exception or not. Where it should use the builders length (not the capacity, a.k.a the internal BytesRef array length). The test failed intermittently about one in 10-20 runs before the change. The test passes successfully 100s of thousands of times with the fix. closes elastic#99649
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 9, 2023
This commit fixes the intermittent failure of BreakingBytesRefBuilderTests. The issue is that the test uses the BreakingBytesRefBuilder's internal BytesRef array length to determine whether to expect a circuit breaker exception or not. Where it should use the builders length (not the capacity, a.k.a the internal BytesRef array length). The test failed intermittently about one in 10-20 runs before the change. The test passes successfully 100s of thousands of times with the fix. closes #99649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the intermittent failure of BreakingBytesRefBuilderTests. The issue is that the test uses the BreakingBytesRefBuilder's internal BytesRef array length to determine whether to expect a circuit breaker exception or not. Where it should use the builders length (not the capacity, a.k.a the internal BytesRef array length).
The test failed intermittently about one in 10-20 runs before the change. The test passes successfully 100s of thousands of times with the fix.
closes #99649